vim plugin not working with option `set autochdir` or when launching vim in a subfolder

[allan-simon]

I'm using neovim and I have in my init.vim the line set autochdir , and it seems to not play nice with phpactor

is it possible for phpactor to try to find in the parent folders if there's a .git folder or composer file in order to choose the root of the project (like many other command line utilities do ) ?

[dantleech]

Phpactor doesn't support this directly but you can provide an anonymous function to detect the project root by g:PhpactorRootDirectoryStrategy (:help phpactor or https://phpactor.readthedocs.io/en/develop/vim-plugin/man.html).

Maybe @przepompownia or @elythyr can recommend a way to use this in conjunction with a root-detection strategy/plugin?

[allan-simon]

@dantleech thanks for the quick answer, as I'm not familiar with anonymous function in vimscript, do you have a quick example of a dirty workaround that would just return always the same root path ?

[dantleech]

Me neither in complete honesty, :help Funcref

I assume something like g:PhpactorRootDirectoryStrategy = function () { return getcwd() } for example.

[allan-simon]

ok thanks, I've seen the "expr-lambda" help but adding in my init.vim

let g:PhpactorRootDirectoryStrategy = {-> '/home/allan/myproject' }

does not seem to work

:Phpactorstatus still return the same working directory :(

[dantleech]

You'd need to restart VIM of course ?

[allan-simon]

haha, I did :) but still does not seem to works

[przepompownia]

@dantleech restarting is not needed. The function is executed each time we call to RPC. @allan-simon do you have the version that uses let g:PhpactorRootDirectoryStrategy? :Phpactorstatus or :checkhealth should print both the version and the working directory.

[przepompownia]

One detail: if you have set the buffer equivalent (b:PhpactorRootDirectoryStrategy) then it takes precedence over the global.

I noticed that we have this possibility undocumented.

Phpactor does not set this buffer variable itself.

[allan-simon]

Version: 111c3e6 (4 days ago) 0.16.1-1083
Filesystems: simple
Working directory: /vagrant/src

I've tripled-checked , I have only g:PhpactorRootDirectoryStrategy defined

Here's my init.vim

set mouse=a
" workaround https://github.com/neovim/neovim/issues/6041
set guicursor=
"
set tabstop=4
set softtabstop=4
set shiftwidth=4
set smarttab

set expandtab
set smartindent

set wildmode=longest,full

set autochdir


set showcmd

colorscheme torte

"the status bar is always displayed
set laststatus=2
if has("statusline")
    set statusline=%<%f%h%m%r%=%l,%c\ %P
elseif has("cmdline_info")
    set ruler " display cursor position
endif


" Specify a directory for plugins
" - For Neovim: ~/.local/share/nvim/plugged
" - Avoid using standard Vim directory names like 'plugin'
call plug#begin('~/.local/share/nvim/plugged')

" for autocompletion

Plug 'Shougo/deoplete.nvim', { 'do': ':UpdateRemotePlugins' }
" for fuzzy completion
Plug 'Shougo/denite.nvim'
Plug 'Shougo/echodoc.vim'
" to display in red extra whitespaces
Plug 'ntpeters/vim-better-whitespace'

Plug 'benekastah/neomake'

Plug 'evidens/vim-twig'
Plug 'phpactor/phpactor', {'for': 'php', 'branch': 'master', 'do': 'composer install --no-dev -o'}
Plug 'kristijanhusak/deoplete-phpactor'

" Initialize plugin system
call plug#end()


" for language server

" used by deoplete
call deoplete#custom#option('ignore_sources', {'php': ['omni']})


let g:PhpactorRootDirectoryStrategy = {-> '/vagrant' }

[przepompownia]

One low-level test (maybe to include in checkhealth in another form):

:echo printf('the type should be %s, is %s', type(function('type')), type(g:PhpactorRootDirectoryStrategy))

[allan-simon]

I got the type should be 2, is 2

[przepompownia]

OK, I reproduced this behaviour on Vim (as opposed to nvim). It seems that calling to RPC behaves with a correctly selected working directory, but we have a bug in status reporting. For test, please display the result of the function directly used for RPC call:

echo phpactor#getRootDirectory()

[przepompownia]

@dantleech is possible that the directories: this given by --working-dir and this resolved by '%project_root%' can differ?

[przepompownia]

But why would it depend on the caller...

I echoed (on Vim) the final command used to RPC call and it have the directory chosen by the strategy.

[allan-simon]

echo phpactor#getRootDirectory()

->

/vagrant

i.e it displays (correctly?) the value defined there

let g:PhpactorRootDirectoryStrategy = {-> '/vagrant' }

(I've tried changing the value to be 100% sure)