Skip to content

Conversation

@micheleorselli
Copy link
Member

@micheleorselli micheleorselli commented Feb 11, 2025

Another step to support php 8.4. To avoid being forced to bump several dependencies to make psalm happy I moved it as a phar and took the chance to update it to the latest version. In order to fix the new errors I tweaked the code here and there. After this one is merged we can try adding php 8.4 in the build matrix to see what happens

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (d4a6463) to head (9b42d43).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #450   +/-   ##
=========================================
  Coverage     94.15%   94.15%           
  Complexity      588      588           
=========================================
  Files            69       69           
  Lines          1590     1590           
=========================================
  Hits           1497     1497           
  Misses           93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micheleorselli micheleorselli marked this pull request as ready for review February 11, 2025 22:58
@micheleorselli micheleorselli merged commit cda58ca into main Feb 12, 2025
30 checks passed
@szepeviktor
Copy link
Contributor

@micheleorselli You can use both shivammathur/setup-php and PHIVE to get those tools as PHAR files.
No need to store (and update?) them in the repository.

@micheleorselli micheleorselli deleted the bump-psalm branch March 13, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants