Remove version from composer.json

[szepeviktor]

Specifying the version yourself will most likely end up creating problems

https://getcomposer.org/doc/04-schema.md#version

[szepeviktor]

for CLI\Version: https://getcomposer.org/doc/07-runtime.md#installed-versions

[AlessandroMinoccheri]

Thanks @szepeviktor for this PR, but if you would like to remove the version from the composer.json file, we should provide a way to print the version in a testable way.
And as you can see, VersionTest is broken.

[szepeviktor]

How about adding version as constant here?

arkitect/src/CLI/Version.php

Line 7 in 92bfae0

class Version

[fain182]

I have read the links above, but if the risk would be that of " Specifying the version yourself will most likely end up creating problems at some point due to human error." then I don't see any advantage in writing the version in one place or another.

If we find a way to avoid writing the version in the repository, so we don't have to update it manually with every release, then that’s a different matter.

[szepeviktor]

While testing it is not possible to get the future version number. (only existing git tags can be queried)

While running:

Composer\InstalledVersions::getVersion('phparkitect/arkitect');

[micheleorselli]

While testing it is not possible to get the future version number. (only existing git tags can be queried)

While running:

Composer\InstalledVersions::getVersion('phparkitect/arkitect');

That should do the trick, we could use it in the Version class instead of parsing the composer.json., defaultingo to UNKNOWN if the class InstalledVersions does not exists. BTW I guess the right package name is

Composer\InstalledVersions::getVersion('phparkitect/phparkitect');

[szepeviktor]

Google Gemini talks about these: https://g.co/gemini/share/dc76096d2ddc

[AlessandroMinoccheri]

@szepeviktor do you wanna try to implement it :) ?

[szepeviktor]

Here it is 🎈

https://github.com/composer/composer/blob/71e8395ebdb68d9179fae53e7fa3a303d6e438f3/src/Composer/InstalledVersions.php#L171

[szepeviktor]

It must be more complicated than I thought ...

--- Expected
+++ Actual
@@ @@
-'0.5.2'
+'dev-f3390ad0a999714bcc718754ad301fd8d8819716'

arkitect/tests/Unit/CLI/VersionTest.php

Line 14 in 3acff7c

$this->assertEquals('0.5.2', Version::get());

[micheleorselli]

It must be more complicated than I thought ...

--- Expected
+++ Actual
@@ @@
-'0.5.2'
+'dev-f3390ad0a999714bcc718754ad301fd8d8819716'

arkitect/tests/Unit/CLI/VersionTest.php

Line 14 in 3acff7c

$this->assertEquals('0.5.2', Version::get());

Considering that with this change everything is managed via composer, does this test still provide value? I'm for removing it

[szepeviktor]

Done 🍏

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (3acff7c) to head (23eba2d).
Report is 4 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #462      +/-   ##
============================================
+ Coverage     94.90%   94.94%   +0.04%     
+ Complexity      605      604       -1     
============================================
  Files            69       69              
  Lines          1609     1603       -6     
============================================
- Hits           1527     1522       -5     
+ Misses           82       81       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[szepeviktor]

Glad to contribute.