Skip to content

Remove redundant ext-json requirement#613

Merged
fain182 merged 1 commit intomainfrom
claude/review-issue-612-HHtZy
Apr 27, 2026
Merged

Remove redundant ext-json requirement#613
fain182 merged 1 commit intomainfrom
claude/review-issue-612-HHtZy

Conversation

@fain182
Copy link
Copy Markdown
Collaborator

@fain182 fain182 commented Apr 26, 2026

Since PHP 8.0, ext-json is bundled into the PHP core and cannot be disabled. Given that the project already requires php ^8.0, declaring ext-json as a separate dependency is unnecessary.

Fixes #612

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.32%. Comparing base (50d789a) to head (a679cc2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #613   +/-   ##
=========================================
  Coverage     98.32%   98.32%           
  Complexity      689      689           
=========================================
  Files            86       86           
  Lines          1968     1968           
=========================================
  Hits           1935     1935           
  Misses           33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Since PHP 8.0, ext-json is bundled into the PHP core and cannot be
disabled. Given that the project already requires php ^8.0, declaring
ext-json as a separate dependency is unnecessary.

Fixes #612
@fain182 fain182 force-pushed the claude/review-issue-612-HHtZy branch from 190b970 to a679cc2 Compare April 27, 2026 09:21
@fain182 fain182 merged commit 44d3a4a into main Apr 27, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant ext-json requirement

2 participants