Don't use echo; but a Response object#5
Merged
gn36 merged 1 commit intophpbb-de:masterfrom Mar 21, 2015
Elsensee:epv-valid
Merged
Don't use echo; but a Response object#5gn36 merged 1 commit intophpbb-de:masterfrom Elsensee:epv-valid
gn36 merged 1 commit intophpbb-de:masterfrom
Elsensee:epv-valid
Conversation
gn36
added a commit
that referenced
this pull request
Mar 21, 2015
Don't use echo; but a Response object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make the epv say: Yay. Valid.
I was told we should use the Response object instead of echo and exit;
Don't know why the diff looks so ugly...