Convert language from using ID nums to ISO names #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxu
reviewed
Mar 18, 2017
|
|
||
| if (!$lang_id) | ||
| { | ||
| throw new \phpbb\boardrules\exception\unexpected_value(array('rule_language', 'WRONG_DATA_LANG', 'UNEXPECTED_VALUE')); |
Contributor
There was a problem hiding this comment.
WRONG_DATA_LANG appears unhandled if you set wrong language iso, like
Contributor
Author
There was a problem hiding this comment.
Yeah I know. I just don't care about that for now. The exceptions classes don't translate that.
Contributor
Author
There was a problem hiding this comment.
OK, this has been solved too now.
migrations/v20x/m15_language_iso.php
Outdated
|
|
||
| namespace phpbb\boardrules\migrations\v20x; | ||
|
|
||
| class m15_language_iso extends \phpbb\db\migration\container_aware_migration |
Contributor
There was a problem hiding this comment.
Container seems not to be used in this migration 😛
Contributor
Author
There was a problem hiding this comment.
Belive me, there are new migration files inbound eventually once I figure a way around postgresql b.s. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpBB seems to use the language's ISO name more than the language's ID. If we switch to using ISO code names we can more easily handle language stuff, such as referencing a board's default lang from the config array. This will also prevent problems if a user deletes, then reinstalls a language pack, which could result in orphaning the rules written in that language (because the ID will change, but the ISO code will remain the same).