Skip to content

Add composer/installers#24

Merged
iMattPro merged 1 commit intophpbb-extensions:masterfrom
michaelcullum:master
Aug 14, 2014
Merged

Add composer/installers#24
iMattPro merged 1 commit intophpbb-extensions:masterfrom
michaelcullum:master

Conversation

@michaelcullum
Copy link
Copy Markdown
Member

No description provided.

@EXreaction
Copy link
Copy Markdown
Contributor

What's this?

@iMattPro
Copy link
Copy Markdown
Contributor

Yes, what's this?

@michaelcullum
Copy link
Copy Markdown
Member Author

<MichaelC|Mobile> naderman: https://github.com/phpbb/phpbb/pull/2874 It all works as well, we are using it to manage extensions on .com (like sortables) and the official extensions on the demo.
<naderman> MichaelC|Mobile: shouldn't people add that if they need it though? we don't have anything we install with that?
<naderman> although I guess once we have some included extensions I suppose we would
<MichaelC|Mobile> well, we'll need it for 3.2 anyway and it's easier handling for phpbb to include it than every extension?
<MichaelC|Mobile> and we don't want extensions to include it now & then add it to the core for 3.2
<MichaelC|Mobile> and break extensions
<MichaelC|Mobile> and if we do every ship with extensions we'd need it then also
<MichaelC|Mobile> ever*
<naderman> every extension that needs it should have it as a dependency
<MichaelC|Mobile> that is every single extension then? :/
<naderman> that's how composer/installers works
<naderman> yes
<naderman> you always specify all your dependencies
<naderman> and that'll be a dependency for installing an extension
<naderman> it makes no sense to put this into phpbb
<MichaelC|Mobile> hm okay
<MichaelC|Mobile> nickvergessen, paul999: ^

because we use "type": "phpbb-extension", every extension needs to include this to be able to be used by composer properly. So it's now going to be a required requirement for all extensions otherwise they won't work in general with 3.2 or using composer for 3.1.

iMattPro added a commit that referenced this pull request Aug 14, 2014
@iMattPro iMattPro merged commit b58880c into phpbb-extensions:master Aug 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants