Conversation
There was a problem hiding this comment.
There is no need for a controller_helper.
|
Just a general note. Please review https://gist.github.com/VSEphpbb/973c06e22abd7c2427c3 as it is already pretty much a working version of the ACP event functions. Also, since you are starting to use language files you should also add them, meaning this PR should also have an info_acp_language file with any of the language variables introduced in this PR. The same goes for the services.yml, there needs to be the event listener service with the configs defined in the constructor of the event listener. |
Manual update using git gitsfile but including permissions Are permissions not needed?
Removing unwanted vars
Copyright date is 2014?
There was a problem hiding this comment.
controller_helper should be removed
There was a problem hiding this comment.
you need the $template var, it's being used now in insert_googleanalytics_id()
3 participants
Should be what's required but added permissions too... tested and working