Conversation
|
There is already a PR working on the event listener. |
There was a problem hiding this comment.
Also, there is no enable setting. Empty GOOGLEANALYTICS_ID var means not enabled.
<!-- IF GOOGLEANALYTICS_ID -->
|
Updated |
There was a problem hiding this comment.
Think core.page_header is a better location?
There was a problem hiding this comment.
Are there any diffrence?
There was a problem hiding this comment.
core.common probably isn't the best, $user isn't setup yet. We don't need $user right now, but if others copy this they may have problems.
There was a problem hiding this comment.
I just figured page_header is a logical choice since we are adding something to the head, and page_header is called for every real page.
|
Updated |
|
Looks great! |
There was a problem hiding this comment.
should the script be indented one tab?
There was a problem hiding this comment.
I don't know. Once it is tabbed, another time it is not tabbed...
There was a problem hiding this comment.
I think it probably should, especially since this is an IF conditional structure.
There was a problem hiding this comment.
It's fine like this as the if and script tags encompass the whole file and quite often we don't indent for if statements in templates.
There was a problem hiding this comment.
Then this is good to merge IMO
There was a problem hiding this comment.
Hit the green button then. 🚢
4 participants
No description provided.