Add extension lang files to extension functional test case#11
Merged
EXreaction merged 2 commits intophpbb-extensions:masterfrom Mar 14, 2014
iMattPro:feature-add-lang
Merged
Add extension lang files to extension functional test case#11EXreaction merged 2 commits intophpbb-extensions:masterfrom iMattPro:feature-add-lang
EXreaction merged 2 commits intophpbb-extensions:masterfrom
iMattPro:feature-add-lang
Conversation
Contributor
There was a problem hiding this comment.
Should return after this or you'll have an error.
Contributor
Author
There was a problem hiding this comment.
It actually doesn't error :)
In the case of passing along an array, lang_path simply won't exist, so no include will be attempted, and an empty array would be merged in to the existing filled lang array.
This is an exact copy of the add_lang() function used in the main phpbb functional test case, only difference being the $lang_path here points to the extension's language files instead of phpBB's language files.
EXreaction
added a commit
that referenced
this pull request
Mar 14, 2014
Add extension lang files to extension functional test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow extensions to load their own lang files in functional testing, and use this->lang() instead of hardcoding language into their tests, e.g.:
This is based off the add_lang() function from the phpbb_functional_test_case