Make PHPBB_BRANCH optional#22
Merged
iMattPro merged 1 commit intophpbb-extensions:3.3.xfrom May 4, 2025
Merged
Conversation
iMattPro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we only have 2 branches here and they should match the PHPBB_BRANCH option, we can just set them by default. That means PHPBB_BRANCH option can be ignored by calling workflows, as users will be choosing the phpBB branch to test when they pick from one of our repo's branches - 3.3.x or master in their calling workflows.