Disable vote button if user already voted#101
Merged
DavidIQ merged 2 commits intophpbb:masterfrom Apr 17, 2018
Merged
Conversation
DavidIQ
reviewed
Apr 17, 2018
| if ($this->user->data['user_id'] == $vote['user_id']) | ||
| { | ||
| $s_voted_up = ((int) $vote['vote_value'] === 1); | ||
| $s_voted_down = ((int) $vote['vote_value'] === 0); |
Member
There was a problem hiding this comment.
Wouldn’t we just break here once we’ve matched on a vote?
Member
Author
There was a problem hiding this comment.
No because we still need to assign template vars for each user who voted, same goes for other comment why we need to go through this. This creates the list of all the users who voted.
DavidIQ
reviewed
Apr 17, 2018
| $event['topic_data']['topic_status'] != ITEM_LOCKED); | ||
|
|
||
| $s_voted_up = $s_voted_down = false; | ||
| if ($idea['idea_votes_up'] || $idea['idea_votes_down']) |
Member
There was a problem hiding this comment.
Maybe also check the $can_vote status here so there’s no need to even go in here.
DavidIQ
approved these changes
Apr 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76