Add post preview capability#106
Merged
DavidIQ merged 2 commits intophpbb:masterfrom Apr 20, 2019
Merged
Conversation
senky
approved these changes
Mar 30, 2019
Member
|
@VSEphpbb I'll test and review these changes in the next few days, had a bit of a busy weekend :) |
battye
approved these changes
Apr 7, 2019
Member
battye
left a comment
battye
left a comment
There was a problem hiding this comment.
Looks fine to me. The changes look good, I've installed and tested the preview feature and that works well. I didn't manually run the tests because it passed Travis CI.
Member
Author
|
@DavidIQ bump |
DavidIQ
approved these changes
Apr 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88
Adding Preview to post editor is a good thing. Not gonna even attempt drafts though, since the Ideas Post handler is totally its own thing separate from phpBB, so it'd just be a whole mess to even try saving drafts I think, after spending some time here with Ideas' post controller.