Skip to content

Use CSS-based thumbs-up/down ratings#114

Merged
DavidIQ merged 26 commits intophpbb:masterfrom
iMattPro:voters
May 15, 2020
Merged

Use CSS-based thumbs-up/down ratings#114
DavidIQ merged 26 commits intophpbb:masterfrom
iMattPro:voters

Conversation

@iMattPro
Copy link
Copy Markdown
Member

@iMattPro iMattPro commented May 7, 2020

Closes #112

CSS based (with FontAwesome) button and thumbs up/down. A little orange check mark is shown if you already voted on the badge that reflects your vote. Also title will show on hover saying if you already voted for/against the idea.

Screen Shot 2020-05-07 at 11 12 02 PM

And in a topic. The check mark will update on the fly if you change your vote or remove your vote.
Screen Shot 2020-05-07 at 11 11 47 PM

@iMattPro iMattPro requested a review from DavidIQ May 7, 2020 02:52
@iMattPro
Copy link
Copy Markdown
Member Author

iMattPro commented May 8, 2020

This PR also fixes a bug I found in the voting system:
If you open an idea that you already voted in, for example you thumbs-upped, then you remove your vote, then you try to put your up-vote back, it will instead count as a down-vote.

@iMattPro
Copy link
Copy Markdown
Member Author

iMattPro commented May 8, 2020

Here's an animation of it working, with the check marks for the user too.
Untitled

@iMattPro
Copy link
Copy Markdown
Member Author

iMattPro commented May 8, 2020

Updated button colors
Screen Shot 2020-05-08 at 11 22 47 AM

@iMattPro
Copy link
Copy Markdown
Member Author

iMattPro commented May 9, 2020

Also just added Ajax loading spinner/inidicators. I've been doing so much test voting I realized the lack of them sucks. Now all ajax ops have a spinner during their operations.

@Dode123
Copy link
Copy Markdown

Dode123 commented May 13, 2020

Updated button colors
Screen Shot 2020-05-08 at 11 22 47 AM

Looks very good @VSEphpbb :)

@iMattPro
Copy link
Copy Markdown
Member Author

Updated animation of it in action
Untitled

@DavidIQ DavidIQ merged commit 6b913ec into phpbb:master May 15, 2020
@iMattPro iMattPro deleted the voters branch May 15, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace thumbs up/down green/red images with CSS

3 participants