[ticket/14831] Fix extension modules installation issues #4491
Conversation
| public function exists($class, $parent, $module) | ||
| { | ||
| // Clear the Modules Cache first to get actual data | ||
| $this->cache->destroy("_modules_$class"); |
There was a problem hiding this comment.
This doesn't seem to work. Method "destroy" not found in \phpbb\cache\service
Shoud maybe switch to the cache driver interface?
There was a problem hiding this comment.
But how did it work before in the add() method and why tests didn't fail on that, just curious. These things with migrations are all weird 😕
|
I guess don't change the cache then...All the other tools use the service too. My IDE just pointed that out, but it could be a magic method. Seems tests fail after changing it. |
PHPBB3-14831
|
It looks like this needs more work as there're some more issues with migrations relying on |
|
The particular problem is that in case |
| public function get_parent_module_id($parent_id, $data = '', $throw_exception = true) | ||
| { | ||
| // Initialize exception object placeholder | ||
| $e = false; |
There was a problem hiding this comment.
Please a better name than just $e
|
I hope this can be !unset WIP now. |
| $parent = $this->get_parent_module_id($parent, $module); | ||
| $parent_sql = 'AND parent_id = ' . (int) $parent; | ||
| $parent = $this->get_parent_module_id($parent, $module, false); | ||
| if ($parent !== false) |
There was a problem hiding this comment.
@rxu maybe just
if ($parent === false)
{
return false;
}
$parent_sql = 'AND parent_id = ' . (int) $parent;
to avoid duplicated construction and simplify the code a little bit?
PHPBB3-14831
[ticket/14831] Fix extension modules installation issues * rxu/ticket/14831: [ticket/14831] Optimize code construction [ticket/14831] Add more tests against UCP modules [ticket/14831] Add more tests, better name for $e placeholder [ticket/14831] Do not throw exception on the module existence checking [ticket/14831] Fix module migrator tool
7 participants
Checklist:
PHPBB3-14831.