This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Small change in the test to pass #107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was not passing because the VM called by travis CI is slow, see below the failure: http://gcov.php.net/viewer.php?version=PHP_HEAD&func=tests&file=ext%2Fzlib%2Ftests%2Finflate_add_basic.phpt So I included the INI section with max_execution_time=10 and the test passed: ===================================================================== Running selected tests. PASS Test incremental inflate_add() functionality [/usr/src/phpt/inflate_add_basic.phpt] ===================================================================== Number of tests : 1 1 Tests skipped : 0 ( 0.0%) -------- Tests warned : 0 ( 0.0%) ( 0.0%) Tests failed : 0 ( 0.0%) ( 0.0%) Expected fail : 0 ( 0.0%) ( 0.0%) Tests passed : 1 (100.0%) (100.0%) User Group: PHPSP #phptestfestbrasil http://phpsp.org.br/
Contributor
|
In CLI, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was not passing because the VM called by travis CI is slow, see below the failure:
http://gcov.php.net/viewer.php?version=PHP_HEAD&func=tests&file=ext%2Fzlib%2Ftests%2Finflate_add_basic.phpt
So I included the INI section with max_execution_time=10 and the test passed:
Running selected tests.
PASS Test incremental inflate_add() functionality [/usr/src/phpt/inflate_add_basic.phpt]
Number of tests : 1 1
Tests skipped : 0 ( 0.0%) --------
Tests warned : 0 ( 0.0%) ( 0.0%)
Tests failed : 0 ( 0.0%) ( 0.0%)
Expected fail : 0 ( 0.0%) ( 0.0%)
Tests passed : 1 (100.0%) (100.0%)
User Group: PHPSP #phptestfestbrasil
http://phpsp.org.br/