This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Add test for posix_getgrnam() basic functionality #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test coverage the function posix_getgrnam() that was not covered yet. http://gcov.php.net/PHP_HEAD/lcov_html/ext/posix/posix.c.gcov.php#1062 Rodrigo Prado de Jesus <royopa [at] gmail [dot] com> User Group: PHPSP #PHPTestFestBrasil
krakjoe
approved these changes
Nov 16, 2017
Contributor
|
@krakjoe I've opened a PR adding a test for the same code against php-src php/php-src#2981 (comment) . Should i open a new PR against this repo? |
Contributor
|
@xrmx the pull requests should now be opened on the php-src again, yes... Thanks. |
Contributor
|
@petk Feel free to reopen this one if that's the right repo php/php-src#2981 |
Contributor
|
Applied via php/php-src@4411cb6 to master and PHP-7.4 branches. I hope the pull request at php-src by @xrmx is ok for @royopa who originally send a pull request. Thank you both for your work 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test coverage the function posix_getgrnam() that was not covered yet.
http://gcov.php.net/PHP_HEAD/lcov_html/ext/posix/posix.c.gcov.php#1062
Rodrigo Prado de Jesus <royopa [at] gmail [dot] com>
User Group: PHPSP #PHPTestFestBrasil