This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Add test for bug #75135 #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I believe you need to add the |
krakjoe
approved these changes
Oct 27, 2017
p365labs
pushed a commit
to p365labs/phptestfest-php-src
that referenced
this pull request
Nov 18, 2017
Improve documentation
carusogabriel
suggested changes
Feb 8, 2019
| unlink($targetDir.DIRECTORY_SEPARATOR.'getBasename_test.txt'); | ||
| rmdir($targetDir); | ||
| ?> | ||
| --XFAIL-- |
Contributor
There was a problem hiding this comment.
We won't accept XFAIL tests 😕
Contributor
|
Hello, thank you for the pull request. It seems that the only proper way here is to fix the mentioned bug instead. XFAIL tests aren't being added in the php-src anymore unfortunately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests that the bug reported in #75135 is actually a bug.
This test was a collaborative effort by the Kansas City PHP User Group on our first meetup for PHPTestFest 2017. Woo!