Adds test for strip_tags string filter #20
Conversation
This adds coverage for the constructor and destructor of the strip_tags filter. Used the sample code from http://php.net/manual/en/filters.string.php
Fix typo in README: agains -> against
| H Hatfield hatfieldje@gmail.com UPHPU Test Fest | ||
| --FILE-- | ||
| <?php | ||
| # vim600:syn=php: |
There was a problem hiding this comment.
| # vim600:syn=php: |
There was a problem hiding this comment.
This one is the only change needed?
There was a problem hiding this comment.
This is copy/paste from whichever test I used as a template. It seems to show up in quite a few files. I have no strong ties to this line, but would like to understand why it should be removed.
There was a problem hiding this comment.
@hhatfield These are so called Vim modes. They are now gone from the php-src in favour of the EditorConfig and manual user side configurations. See this change:
php/php-src@92ac598
and here https://externals.io/message/101206
Yes, they were present once in some of those files. Some are still there but only on very rare places (for eample *.w32 files to enable syntax highlighting and for some documentation purposes). Long term: they should all be replaced with different approaches. For example, EditorConfig once more options will be available.
|
@carusogabriel if all other things here are good, I'll merge this one also then... Maybe also |
|
@petk Go ahead then. |
|
@carusogabriel the string.strip_tags has been deprecated in PHP 7.3... 🙄 |
|
If so, @hhatfield thanks for the PR, but it's not valid anymore 😕 |
4 participants
This adds coverage for the constructor and destructor of the strip_tags filter. Also tests the sample code from http://php.net/manual/en/filters.string.php
UPHPU TestFest