This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Added test for php_ini_scanned_files #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This was done at Madison PHP phptestfest |
krakjoe
suggested changes
Oct 25, 2017
Contributor
krakjoe
left a comment
krakjoe
left a comment
There was a problem hiding this comment.
You cannot rely on compile time configuration dependant behaviour in tests: CI may use a recipe for their build that is entirely different to mine ... my builds will always have scan dir set and will always fail this test ...
Possible solution is a skipif section that runs the test based on the precondition that PHP_INI_SCAN_DIR is not set ...
Author
|
Hi Joe,
Thank you for reviewing this and I appreciate the feedback as I am a fairly new PHP developer, I will look into this as I didn't realize that was the case regarding scan dir in your build.
Thank you,
Derek
…________________________________
From: Joe Watkins <notifications@github.com>
Sent: Wednesday, October 25, 2017 2:40:55 AM
To: phpcommunity/phptestfest-php-src
Cc: Derek Hobbs; Author
Subject: Re: [phpcommunity/phptestfest-php-src] Added test for php_ini_scanned_files (#25)
@krakjoe requested changes on this pull request.
You cannot rely on compile time configuration dependant behaviour in tests: CI may use a recipe for their build that is entirely different to mine ... my builds will always have scan dir set and will always fail this test ...
Possible solution is a skipif section that runs the test based on the precondition that PHP_INI_SCAN_DIR is not set ...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#25 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AQe4wiXtDrN1EOoiPV4sRXChriEil8sTks5svuYHgaJpZM4PhauF>.
|
p365labs
pushed a commit
to p365labs/phptestfest-php-src
that referenced
this pull request
Nov 18, 2017
Generate phpt
Contributor
|
Thank you for the pull request. Since we can't know the status of this pr anymore, I'll be merging the rest of the contributions in a single commit... More info on this soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.