This repository was archived by the owner on Aug 24, 2021. It is now read-only.
test readline() with EOF returns false #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
approved these changes
Oct 25, 2017
Contributor
krakjoe
left a comment
krakjoe
left a comment
There was a problem hiding this comment.
This extension has surprisingly crappy coverage, guess there is more low hanging fruit to be harvested here ...
Author
|
Probably doesn't help that I think in alot of the images people are using at testfests, readline isn't enabled - had to jump through a couple of hoops to get readline working when I was at Madison. Fine if you know what you are doing, but if you're used to just using dnf or apt-get or whatever, perhaps a bit of a roadblock? |
p365labs
pushed a commit
to p365labs/phptestfest-php-src
that referenced
this pull request
Nov 18, 2017
Added new resource
Contributor
|
@liam-wiltshire What line were you trying to coverage? |
Contributor
|
Thank you for the pull request. Since we can't know the status of this pr anymore, I'll be merging the rest of the contributions in a single commit... More info on this soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Group: Madison PHP
Tests that passing EOF (Ctrl+D) to readline returns false