Skip to content
This repository was archived by the owner on Aug 24, 2021. It is now read-only.

Conversation

@ericpoe
Copy link
Contributor

@ericpoe ericpoe commented Sep 23, 2017

IteratorIterator is supposed to be an outer-iterator for anything that implements \Traversable. In other words, this provides next(), current(), rewind(), key(), and valid() for the traversable object. However, when an IteratorIterator is wrapped around DOMNodeList (which implements \Traversable), the innerIterator is no longer traversable via foreach.

User Group: Kansas City PHP

p365labs pushed a commit to p365labs/phptestfest-php-src that referenced this pull request Nov 18, 2017
Fixing typos and command references
print "Key: ".$k." Item: ".$item->nodeName. " Value: ".$item->nodeValue. PHP_EOL;
}
?>
--XFAIL--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't accept XFAIL tests 😕

@petk
Copy link
Contributor

petk commented Feb 11, 2019

Hello, thank you for the pull request. It seems that XFAIL tests are not being accepted in the php-src repository anymore. However, a better way here is to try to fix the mentioned bug instead.

@petk petk closed this Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants