Skip to content
This repository was archived by the owner on Aug 24, 2021. It is now read-only.

Conversation

@globtec
Copy link

@globtec globtec commented Oct 28, 2017

Added basic success test for stream_get_filters function

Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this function is already been tested http://gcov.php.net/PHP_HEAD/lcov_html/ext/standard/user_filters.c.gcov.php.

@carusogabriel
Copy link
Contributor

Closing as we already have tests for that upstream.

@petk
Copy link
Contributor

petk commented Feb 14, 2019

Hello, this one shows here as not tested yet:
http://gcov.php.net/viewer.php?version=PHP_HEAD&func=tested_functions

Also, I'm not sure there are *.phpt files containing tests for stream_get_filters() specifically.

@petk
Copy link
Contributor

petk commented Feb 14, 2019

cc @carusogabriel when you have some time, do you maybe have any explanation please why the gcov doesn't have this marked as tested? Should we recheck this one? Thank you...

@carusogabriel
Copy link
Contributor

@petk I don't remember why, but the "Tested Functions" page isn't trustable. The "Coverage" one is.

@petk
Copy link
Contributor

petk commented Feb 14, 2019

Ok, thanks for the info... What about that these aren't even anywhere in the *.phpt files in the --FILE-- sections? For example, from my quick search, the only 3 occurrences in tests are:

  • ext/standard/tests/filters/chunked_001.phpt
  • ext/standard/tests/filters/stream_filter_remove_basic.phpt
  • ext/standard/tests/filters/stream_filter_remove_error.phpt

in the --SKIPIF-- section. Is that fine?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants