This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Add test case for pcntl_setpriority basic behaviour #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
suggested changes
Oct 31, 2017
Contributor
There was a problem hiding this comment.
We can't have tests that assume supercow powers by default ...
I'm not sure about this, but maybe you could find a way to skipif ... maybe dig about in other tests to see if any other test is doing the same sort of thing ...
Additionally, this function may not always be available when pcntl is loaded, requires skipif on function exists ...
Contributor
Author
|
@krakjoe Skipif for function_exists is there. |
Contributor
Author
|
Fixed. Testing for $_SERVER['SUDO_USER'] was the best solution I could find. |
carusogabriel
approved these changes
Feb 9, 2019
Contributor
|
Applied via php/php-src@eadfdb9 to the php-src repository master and PHP-7.4 branches. Thank you @galvao for the pull request 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test case for pcntl_setpriority basic behaviour assuming the user has superuser permission