This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Small changes in test to make pass #86
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was not passing because the VM called by travis CI is slow, see below the failure: http://gcov.php.net/viewer.php?version=PHP_HEAD&func=tests&file=Zend%2Ftests%2Fconcat_003.phpt
|
👏 |
Contributor
|
I'm unsure what is supposed to be happening here ... it used to be skipped in debug, and now will only run in debug ? |
Contributor
Author
|
The test is slower, so in my opinion then this test should only be run if debug mode is enabled. What do you think about it? The message that was explained the skip previously (see below) was not enlightening to me: Can you explain what the message means? |
Contributor
|
Thank you for the pull request. Since we can't know the status of this pr anymore, I'll be merging the rest of the contributions in a single commit... More info on this soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was not passing because the VM called by travis CI is slow, see below the failure:
http://gcov.php.net/viewer.php?version=PHP_HEAD&func=tests&file=Zend%2Ftests%2Fconcat_003.phpt
User Group: PHPSP #phptestfestbrasil
http://phpsp.org.br/