This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Provide test for bug #68004 #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
approved these changes
Oct 25, 2017
p365labs
pushed a commit
to p365labs/phptestfest-php-src
that referenced
this pull request
Nov 18, 2017
How to PHPT documentation
carusogabriel
suggested changes
Feb 9, 2019
| echo 'Limit 2: ', iterator_count(new LimitIterator($iterator, 2)), ' ', iterator_count(new LimitIterator($tmpCsvFile, 2)), "\n"; | ||
| echo 'Limit 3: ', iterator_count(new LimitIterator($iterator, 3)), ' ', iterator_count(new LimitIterator($tmpCsvFile, 3)), "\n"; | ||
| ?> | ||
| --XFAIL-- |
Contributor
There was a problem hiding this comment.
We won't accept XFAIL tests 😕
Contributor
|
Hello, thank you for the pull request. The XFAIL tests for the PHP-7.4 and master branches should instead go one step further and try to fix the bug if possible. The XFAIL tests are not being merged to the php-src repository anymore. Thanks and sorry for inconvenience. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a test for bug #68004
One interesting aspect of this test is that it creates a tiny temp file in memory (when smaller than 2MB) that gets destroyed when this test gets destroyed. That should be faster than creating a file on the filesystem and then going through a cleanup script when the test is finished.
SplTempFileObject()FTW!KCPHPUG TestFest 2017