This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Confirm mb_split's mishanding of '\B' (bug #69433) #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the result of passing the regex '\B' to mb_split on English and Chinese characters, and note the invalid unicode characters in the result.
krakjoe
approved these changes
Nov 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the result of passing the regex '\B' to mb_split
on English and Chinese characters, and note the invalid
unicode characters in the result. NOTE: The 3-Byte Chinese characters and
malformed UTF-8 might not display properly on your editor. Furthermore, text editors
may also corrupt the file when saving it. I've found command line git and less to be
the only things that handle it correctly by default.