Type of value returned by Sql2ToQomQueryConverter::parseLiteral becomes more accurate #46
Conversation
There was a problem hiding this comment.
i am not sure if that is correct. should those not become real boolean, aka false and true? the jackrabbit backend for example will use the java logic where every string except "true" is false - i would want to keep the boolean type here as well.
|
ping |
1 similar comment
|
ping |
|
I'm sorry for my abscense. Yes it makes sence to return boolean. I decided to return strings in previous pr because in mysql boolean values are stored as '1' or '0' |
|
I've just made a PR to jackalope-doctrine-dbal that depends on this PR. All tests are passed with these two PRs (I tested with mysql and sqlite) except |
There was a problem hiding this comment.
according to http://php.net/manual/de/function.is-numeric.php php does not accept , as separator even when the locale is different than english. so this seems correct.
Type of value returned by Sql2ToQomQueryConverter::parseLiteral becomes more accurate
|
thanks a lot. the test failure about multivalue is not related to this PR |
2 participants
...more accurate