Skip to content

Type of value returned by Sql2ToQomQueryConverter::parseLiteral becomes more accurate #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2013
Merged

Type of value returned by Sql2ToQomQueryConverter::parseLiteral becomes more accurate #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ca9397
Type of value returned by Sql2ToQomQueryConverter::parseLiteral becom…
lex009 Mar 26, 2013
131c50e
parseLiteral returns boolean type in case 'false' or 'true'
lex009 Jun 8, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/PHPCR/Util/QOM/Sql2ToQomQueryConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,13 @@ protected function parseLiteral()
throw new \Exception("Syntax error: unterminated quoted string $token in '{$this->sql2}'");
}

$token = substr($token, 1, -1);
$token = substr($token, 1, -1);
Copy link
Member

@dbu dbu Mar 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an indention change on this line.

Copy link
Member

@dbu dbu Jun 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in d1edda0

} else if (is_numeric($token)){
$token = strpos($token, '.') === false ? (int) $token : (float) $token;
Copy link
Member

@dbu dbu Jun 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to http://php.net/manual/de/function.is-numeric.php php does not accept , as separator even when the locale is different than english. so this seems correct.

} else if ($token == 'true') {
$token = true;
} else if ($token == 'false') {
$token = false;
}

return $this->factory->literal($token);
Expand Down