NodeTouchCommand failing on windows

[vstm]

The NodeTouchCommand uses dirname and basename for operations on PHPCR-paths. This causes problems because Windows might return \ instead of / as the root-path.

It breaks the unit test completely:

C:\[...]\jackalope-doctrine-dbal> phpunit
...  
Fatal error: Call to a member function addNode() on a non-object in C:\[...]\NodeTouchCommand.php on line 143

And just throws an exception if you want to "touch" a node:

C:\[...]\jackalope-doctrine-dbal> php bin\jackalope phpcr:node:touch /gopf --type nt:unstructured

  [PHPCR\RepositoryException]
  Not an absolute path '\'

This pull request solves the problem by simply replacing the "php-based" filesystem-functions with the PathHelper-counterparts.

[dantleech]

My bad :) Thanks for the fix!

[lsmith77]

we should probably grep all bundles, jackalope and phpcr repositories for dirname calls

[dbu]

found one dirname in symfony-cmf that i fiexed symfony-cmf/search-bundle@27edcab

[dbu]

and some basename calls fixed too symfony-cmf/tree-browser-bundle@38b4d06 and symfony-cmf/routing-bundle@c5c1f9c and symfony-cmf/routing-auto-bundle@ac719e9

[dbu]

jackalope and phpcr where cleaned up a moment ago when we created the PathHelper - i think this one just sneaked in. re-checked, there are no other occurrences currently.