Skip to content

fix for CharacterTest::testPropertyWithQuotes #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lsmith77 merged 1 commit into from
Jul 10, 2013
Merged

fix for CharacterTest::testPropertyWithQuotes #82

lsmith77 merged 1 commit into from
Jul 10, 2013

Conversation

@lsmith77
Copy link
Member

@lsmith77 lsmith77 commented Jul 8, 2013

@wjzijderveld
Copy link

wjzijderveld commented Jul 9, 2013

Seems ok to me.
Only think I thought, maybe we should also allow escaping with a double quoteCharacter (as MySQL, pgSql and SQLite do).

@wjzijderveld wjzijderveld mentioned this pull request Jul 9, 2013
Merged
lsmith77 added a commit that referenced this pull request Jul 10, 2013
@lsmith77
Merge pull request #82 from phpcr/fix_parsing_of_escaped_double_quote
4c304fd 
fix for CharacterTest::testPropertyWithQuotes
@lsmith77 lsmith77 merged commit 4c304fd into master Jul 10, 2013
@lsmith77 lsmith77 deleted the fix_parsing_of_escaped_double_quote branch July 10, 2013 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsmith77 @wjzijderveld