feat(deployments): add per-site Deployments + deploy script#24
Merged
Conversation
First 4-level-deep nested resource: $forge->server($s)->site($id)->deployments()/->deployment($d)/ ->deploy()/->deploymentScript(). - Data\Deployment (nested Data\DeploymentCommit value object, started_at/ ended_at nullable for queued deploys), Data\DeploymentScript - Data\UpdateDeploymentScriptData, Data\ListDeploymentsOptions (sort + filter[commit_hash|commit_message|commit_author]) - Enums\DeploymentStatus - Requests: GetDeployments, GetDeployment, TriggerDeployment (POST), GetDeploymentScript, UpdateDeploymentScript (PUT) - Resources\DeploymentsResource (all/iterate/trigger), DeploymentResource (get), DeploymentScriptResource (get/update) - SiteResource sugar: deploy() over deployments()->trigger() Fixtures recorded against a real GitHub-connected Laravel site deployed via the SDK itself (deploy script fixed through deploymentScript()->update() to run composer install before artisan). DeploymentFixture redacts the script content, the commit author, and pagination cursors. 401 tests / 774 assertions / 100% coverage. Closes #8. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 task
fbarrento
added a commit
that referenced
this pull request
May 24, 2026
…it (#28) Folds the divergences that had only lived in PR descriptions into docs/FINDINGS.md: ssh-key create 202-empty, the four Sites findings (server-less GET, runtime-required domain_mode, fresh-site nulls, PUT-empty), the deployments script/trigger notes, the two daemon findings (update needs config, install-state race), and the fixture-redaction hardening from the security audit (#27). Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First 4-level-deep nested resource —
$forge->server($s)->site($id)->deployments()/->deployment($d)/->deploy()/->deploymentScript(). The convenience entry point most Forge automation needs.Data\Deployment(nestedData\DeploymentCommit;started_at/ended_atnullable for queued deploys) +Data\DeploymentScriptData\UpdateDeploymentScriptData,Data\ListDeploymentsOptions(sort +filter[commit_hash|commit_message|commit_author])Enums\DeploymentStatusGetDeployments,GetDeployment,TriggerDeployment(POST),GetDeploymentScript,UpdateDeploymentScript(PUT)Resources\DeploymentsResource(all/iterate/trigger),DeploymentResource(get),DeploymentScriptResource(get/update)SiteResource::deploy()sugar overdeployments()->trigger()Recording notes
Fixtures recorded against a real GitHub-connected Laravel site, deployed end-to-end via the SDK itself — the deploy initially failed (
phpsite default script ranartisanbefore deps existed), so I fixed it through the newdeploymentScript()->update()(composer install first) and re-deploy()ed to green.DeploymentFixtureredacts the scriptcontent, the commitauthor, and pagination cursors.Test plan
composer test— pint, rector, phpstan, 401 tests / 774 assertions, 100% coverage.🤖 Generated with Claude Code