Add real name checking for Signoff and some enhancements

[williamdes]

• Check that Signed-off-by is a real name
• Update README.md (document events and payload types)
• Removed hard coded repository name
• Moved the secret to the config file
• Improved code (True > true)
• More changes

---

• Tested against all our signoff lines found on the main repo.
• Supports weird accents

Have a look at the comment below !

[williamdes]

⚠️ ⛑️ Before you pull any changes, go to hooks/github.php and copy the value of hook_secret into a safe place.
Then pull the changes and add define('GITHUB_HOOK_SECRET', 'secretHere!!'); to hooks/config.php with the value of the previously copied secret

[williamdes]

A preview of the message

[williamdes]

Hello @ibennetch @nijel can you please review my changes?

Btw I tested the changes on my personal test repo.

[nijel]

The changes look okay to me.

BTW: There is also https://github.com/apps/dco which might be used out of the box instead of implementing own code (not sure how it compares, I use this one for @WeblateOrg).

[williamdes]

BTW: There is also https://github.com/apps/dco which might be used out of the box instead of implementing own code (not sure how it compares, I use this one for @WeblateOrg).

@nijel I did not find a way to add a pattern to dco bot and it generates false positives when checking the email for users using a different email or using the privacy email settings.

[nijel]

Okay, I just wanted to mention alternative :-).

[ibennetch]

Looks good to me, I added one note about the link to the DCO but otherwise it's great. Thanks for this work.

[williamdes]

@ibennetch Can you please install the PR on the server ?
or @nijel ?

PS: dot not forget to read the instructions #19 (comment)

[ibennetch]

I have completed the installation on the server.

I've even tested it with phpmyadmin/phpmyadmin#15340 and it looks great. Thanks.

[williamdes]

Thanks for installing the PR :)
You will new see checked green on webhooks list on each repo since I implemented 🏓 ping requests (github zen) instead of red cross for 500 errors