Skip to content

Conversation

@shucon
Copy link
Contributor

@shucon shucon commented Oct 12, 2020

Fixes: #299

The issue was caused because the value of token FALSE became boolean instead of string.

Signed-off-by: Saksham Gupta shucon01@gmail.com

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #314 into QA will decrease coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                 QA     #314      +/-   ##
============================================
- Coverage     99.71%   99.69%   -0.03%     
- Complexity     1906     1908       +2     
============================================
  Files            63       63              
  Lines          4593     4598       +5     
============================================
+ Hits           4580     4584       +4     
- Misses           13       14       +1     
Impacted Files Coverage Δ Complexity Δ
src/Components/AlterOperation.php 98.83% <87.50%> (-1.17%) 32.00 <0.00> (+2.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2467ef...512db63. Read the comment docs.

@williamdes
Copy link
Member

Could you add some phpunit tests to cover this cases ?

@williamdes williamdes added this to the 4.7.1 milestone Oct 12, 2020
@shucon
Copy link
Contributor Author

shucon commented Oct 12, 2020

Hey, I've added a test but I'm not sure whether that's how it's supposed to be.

Copy link
Member

@ibennetch ibennetch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this LGTM. Thank you.

shucon and others added 2 commits October 13, 2020 15:17
…LT FALSE" token

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 9b2d4ca into phpmyadmin:QA Oct 13, 2020
@williamdes williamdes self-assigned this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants