Fix/5.9.x missing with parser token #574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est case, now without parsing errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.9.x #574 +/- ##
=========================================
Coverage 96.79% 96.79%
- Complexity 2257 2258 +1
=========================================
Files 69 69
Lines 5172 5174 +2
=========================================
+ Hits 5006 5008 +2
Misses 166 166 ☔ View full report in Codecov by Sentry. |
iifawzi
reviewed
Aug 26, 2024
Contributor
|
Super 🚀 , thank you! |
Contributor
Author
|
@MauricioFauth As you merged #575, I think you can also merge this one. I know there are 2 failing chekcs but these are because of benchmarks not being properly configured. That's fixed on 5.10.x branch, and out of this scope. Thanks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #563