Skip to content

Fix: Correct option parameter parsing in ConsoleStrategy #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexstandiford merged 5 commits into from
Jan 12, 2026
Merged

Fix: Correct option parameter parsing in ConsoleStrategy #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a2fb74
Fixes error
alexstandiford Jan 12, 2026
c336f50
Adds test coverage
alexstandiford Jan 12, 2026
4a00220
Adds test coverage
alexstandiford Jan 12, 2026
d603e66
Adds test coverage
alexstandiford Jan 12, 2026
99cfc0f
Adds test coverage
alexstandiford Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/dependabot.yml
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions .github/workflows/phpstan.yml
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions .github/workflows/phpunit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ jobs:
- uses: actions/checkout@v3

- uses: php-actions/composer@v6
with:
php_version: "8.3"

- name: PHPUnit Tests
uses: php-actions/phpunit@v3
with:
php_version: "8.3"
version: "9.6"
configuration: phpunit.xml
14 changes: 0 additions & 14 deletions .github/workflows/spellcheck.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lib/Strategies/ConsoleStrategy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ private function parseSignature(string $signature): array
}

if ($isOption) {
$name = Str::trimLeading($raw, '-');
$name = Str::trimLeading($raw, '--');
Comment thread
alexstandiford marked this conversation as resolved.

if (Str::contains($name, '=')) {
[$name, $default] = explode('=', $name, 2);
Expand Down
3 changes: 1 addition & 2 deletions tests/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?php

namespace PHPNomad\Core\Tests;

namespace PHPNomad\Integrations\WordPress\Tests;

use PHPNomad\Tests\TestCase as CoreTestCase;

Expand Down
Loading