Relax TTL test and run a smaller cluster in GitHub Actions#2040
Merged
michael-grunder merged 2 commits intodevelopfrom Dec 2, 2021
Merged
Relax TTL test and run a smaller cluster in GitHub Actions#2040michael-grunder merged 2 commits intodevelopfrom
michael-grunder merged 2 commits intodevelopfrom
Conversation
The previous logic was timing related and also kind of testing Redis' expiration logic itself.
michael-grunder
added a commit
that referenced
this pull request
Dec 7, 2021
* Fix expire check in testttl The previous logic was timing related and also kind of testing Redis' expiration logic itself. * Use a smaller cluster in GitHub CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wild guess that perhaps resource exhaustion is causing our flaky
testTimecluster test.