Remove Warning for array_key_exists#468
Merged
Landerstraeten merged 2 commits intophpro:masterfrom Feb 16, 2018
Kanti:patch-1
Merged
Remove Warning for array_key_exists#468Landerstraeten merged 2 commits intophpro:masterfrom Kanti:patch-1
Landerstraeten merged 2 commits intophpro:masterfrom
Kanti:patch-1
Conversation
Remove Warning: array_key_exists() expects parameter 2 to be array, null given in /var/www/secure_login/vendor/phpro/grumphp/src/Configuration/Compiler/TaskCompilerPass.php on line 37
|
|
||
| $tasksRegistered[] = $configKey; | ||
| if (!array_key_exists($configKey, $configuration)) { | ||
| if (!array_key_exists($configKey, $configuration?:[])) { |
Contributor
There was a problem hiding this comment.
I would leave this as it is and change line 22.
$configuration = $container->getParameter('tasks') ?: [];
Contributor
Author
|
@Landerstraeten I have changed it |
Contributor
|
Thank you @Kanti! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On install of grumphp without an grumphp.yml file I get this Warning:
Warning: array_key_exists() expects parameter 2 to be array, null given in /var/www/secure_login/vendor/phpro/grumphp/src/Configuration/Compiler/TaskCompilerPass.php on line 37
Wit my Proposed Changes this warning will be removed.