Fix xsd:language-like simple type generations.#592
Merged
veewee merged 1 commit intophpro:v4.xfrom Oct 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the type generation for xsd:language-like simple types by ensuring they resolve to their base PHP types (e.g., string) instead of generating unnecessary custom class references.
Key Changes:
- Added logic to detect simple types with known base types and return the base type directly
- Added comprehensive test coverage for various type resolution scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Phpro/SoapClient/CodeGenerator/Model/Property.php |
Added conditional check to return base type for simple types with known base types |
test/PhproTest/SoapClient/Unit/CodeGenerator/Model/PropertyTest.php |
Added new test method with data provider covering type resolution for simple types, namespaced types, and root namespace types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #591
This enhances
xsd:language-like type generations fromto