V3 to v4 updates#4
Merged
terrafrost merged 5 commits intophpseclib:mainfrom Mar 12, 2026
Merged
Conversation
hulkoba
commented
Mar 11, 2026
| { | ||
| public function foo() | ||
| { | ||
| $spkac = CRL::loadCRL($privKey->getPublicKey()); |
Contributor
Author
There was a problem hiding this comment.
Heya 👋 The given differences table shows the line $spkac = new CRL::loadCRL($privKey->getPublicKey()); which is invalid php. So we added $spkac = CRL::loadCRL($privKey->getPublicKey()); instead. Let us know if and how we should change it.
Member
There was a problem hiding this comment.
Oh! That should be $pkac = new SPKAC($privKey->getPublicKey()) - sorry about that!
I'll try to look over this this evening (it's the morning in the timezone I'm in) and merge it in.
Thanks!
Member
|
Aside from what I've previously mentioned this PR looks good! Nice job!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is conducted in accordance with "Milestone 1: Write RectorPHP rules to upgrade phpseclib 3.0 to 4.0" as outlined in the Scope of Work for the Sovereign Tech Agency Resilience Program.
This PR: