Add # as vallid character for variable.#218
Closed
Blurazzle wants to merge 1 commit intophpstan:1.23.xfrom
Closed
Conversation
Add # as vallid character for variable.
Member
|
We can't do this change so lightly. It's a BC break and it's questionable whether we even want that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is related to the issue phpstan/phpstan#9919 (comment). The problem that it resolves can be seen in https://phpstan.org/r/459a7de6-aa15-42ee-8967-0777088f411e.
Our application is connected to an IBM i DB2 database. The column names are sometimes like the following
Currently, the lexer does not recognize these as valid property names, while in fact, these are valid properties in PHP that can be accessed with $this->{'PBGD#L'} syntax.