Skip to content

Fix: Remove expected error message #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Fix: Remove expected error message #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tests/Rules/Deprecations/CallToDeprecatedStaticMethodRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ public function testDeprecatedStaticMethodCall(): void
'Call to deprecated method deprecatedFoo2() of class CheckDeprecatedStaticMethodCall\Foo.',
13,
],
[
'Call to deprecated method deprecatedFoo() of class CheckDeprecatedStaticMethodCall\Foo.',
Copy link
Contributor Author

@localheinz localheinz Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of

phpstan-deprecation-rules/src/Rules/Deprecations/CallToDeprecatedStaticMethodRule.php

Lines 43 to 45 in 1ed86a5

if (DeprecatedScopeHelper::isScopeDeprecated($scope)) {
return [];
}

and

phpstan-deprecation-rules/tests/Rules/Deprecations/data/call-to-deprecated-static-method-definition.php

Lines 13 to 19 in 1ed86a5

/**
* @deprecated
*/
public static function deprecatedFoo()
{
}

and

phpstan-deprecation-rules/tests/Rules/Deprecations/data/call-to-deprecated-static-method.php

Lines 18 to 22 in 1ed86a5

public static function deprecatedFoo()
{
parent::foo();
parent::deprecatedFoo();
}

we never enter the scope of the deprecated method Bar::deprecatedFoo().

21,
],
]
);
}
Expand Down