Fix assertions for phpstan master #51
Conversation
| ], | ||
| [ | ||
| 'Call to deprecated method deprecatedFoo() of class CheckDeprecatedStaticMethodCall\Foo.', | ||
| 24, |
There was a problem hiding this comment.
Thank you! One more thing I need here is to actually add a test that checks that this scenario is continuted to be reported in a valid scenario, e.g. calling parent::deprecatedFoo(); in a scope that's not deprecated. Thanks.
There was a problem hiding this comment.
Hm ok. I will see if I can get that fixed. If not I will let you know
There was a problem hiding this comment.
If I understood your post correctly, I think this has been added back in another way now?
There was a problem hiding this comment.
No, it's just that this extension is built with latest stable PHPStan version and not with dev-master. Update the composer.json for the purpose of this PR :)
There was a problem hiding this comment.
Yes, I know that. I was referring to the actual meaning of your sentence 🤓
Anyway updates composer.json as well now
|
Thank you! Merged as: 2cbafb6 |
2 participants
This fixes #50