Specify types for Doctrine Collection first() method #153
Conversation
There was a problem hiding this comment.
Please also add an integration test about this scenario.
You can see here how these things are tested: https://github.com/phpstan/phpstan-doctrine/tree/master/tests/DoctrineIntegration/ORM
|
|
||
| return $this->typeSpecifier->create( | ||
| new MethodCall($node->var, self::FIRST_METHOD_NAME), | ||
| TypeCombinator::remove(ParametersAcceptorSelector::selectSingle($methodVariants)->getReturnType(), new BooleanType()), |
There was a problem hiding this comment.
Since we're executing this now for all contexts, there should be an if-else about $context->truthy() and $context->falsey(). In the former case, isFirst is going to return false, in the second case, the false should be removed.
There was a problem hiding this comment.
I have added a condition, but it doesn't have any effect for some reason. The errors "Cannot call method on" still remain.
|
Hi, I'm sorry, you'll have to debug it yourself, I can't dive into this right now. |
ondrejmirtes
force-pushed
the
master
branch
4 times, most recently
from
b2b2414 to
1fe21ab
Compare
|
Can be closed as #172 is merged. |
3 participants
An attempt to solve #152.
PHPStan gives me a new error
Call to method Doctrine\Common\Collections\Collection<int,App\Entity\MyEntity>::isEmpty() will always evaluate to false., andCannot call method onerrors are still there.