Test that UniqueConstraintViolationException from EntityManager::flush() is not marked as dead catch
#315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasekPurchart
force-pushed
the
flush-exception-tests
branch
from
d0b145f to
35c5fe1
Compare
ondrejmirtes
requested changes
Apr 6, 2022
|
|
||
| protected function getRule(): Rule | ||
| { | ||
| return new CatchWithUnthrownExceptionRule(); |
There was a problem hiding this comment.
You should be able to get rid of the BC message with: self::getContainer()->getByType(CatchWithUnthrownExceptionRule::class);
…h() is not marked as dead catch
VasekPurchart
force-pushed
the
flush-exception-tests
branch
from
35c5fe1 to
30cc417
Compare
ondrejmirtes
approved these changes
Apr 6, 2022
|
Thank you! |
gbirke
added a commit
to wmde/fundraising-payments
that referenced
this pull request
Aug 3, 2023
This is a temporary workaround for the changes made in Doctrine ORM 2.16, discussed in doctrine/orm#10785 When that discussion is resolved, we should remove the check for `RuntimeException`, because it might be thrown by other errors that have nothing to do with duplicate IDs, which would lead to our `PaymentOverrideException` hinting at the wrong thing. Also remove the PHPStan rule that had an exception for this check. When the Exception comes back, the method should have an annotation that it's thrown. Otherwise we'll have to put the PHPStan rule back or try out phpstan-doctrine where this has been solved: phpstan/phpstan-doctrine#315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for #313 .