Add impure annotation in some Collection methods #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Lowest failure are unrelated since they are on the 1.3.x branch. |
ondrejmirtes
requested changes
Dec 19, 2022
|
|
||
| $result2 = $collection->last(); | ||
| $result2; | ||
| } |
Member
There was a problem hiding this comment.
Please do not modify the test like that, the diff of the rule test case is unreadable. Also, it'd make sense to refactor this into a TypeInferenceTestCase :) Thank you.
Contributor
Author
There was a problem hiding this comment.
The test is now refactored into a TypeInferenceTestCase ;)
VincentLanglet
force-pushed
the
impure
branch
2 times, most recently
from
eaf45d3 to
64f93d5
Compare
VincentLanglet
force-pushed
the
impure
branch
from
64f93d5 to
5013e0f
Compare
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203