Use dynamic throw type extension on EntityManagerInterface::flush #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Nov 13, 2023
| return TypeCombinator::union( | ||
| ...array_map(static function ($class): Type { | ||
| return new ObjectType($class); | ||
| }, self::SUPPORTED_METHOD[$methodReflection->getName()]) |
Member
There was a problem hiding this comment.
This needs a test. You can create a new test case for the corresponding rule, and fetch the rule with self::getContainer()->getByType(....
Contributor
Author
There was a problem hiding this comment.
This seems covered by
https://github.com/phpstan/phpstan-doctrine/blob/1.3.x/tests/Rules/Exceptions/data/unthrown-exception.php#L21-L25
to me.
I tried to comment the whole if in the getThrowTypeFromMethodCall, and tests were failing.
Member
There was a problem hiding this comment.
If your src/ does not change anything about test results then it's not needed.
Please show why your change is needed by writing a failing test first.
Contributor
Author
There was a problem hiding this comment.
I added another test which fail without this change.
VincentLanglet
force-pushed
the
fix/entityManagerFlush
branch
2 times, most recently
from
4fc9d89 to
8f9b30e
Compare
VincentLanglet
force-pushed
the
fix/entityManagerFlush
branch
from
8f9b30e to
365f722
Compare
ondrejmirtes
approved these changes
Nov 13, 2023
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.