Add throws annotation on EntityManagerInterface::flush

[VincentLanglet]

This is the same than #313 but on the EntityManagerInterface in order to avoid the deadcatch with

try {
    $this->entityManagerInterface->flush();
} catch (\Doctrine\DBAL\Exception\UniqueConstraintViolationException $e) {
    // pass
}

or avoid but it's not thrown. phpstan error.

Injecting the interface rather than EntityManager is a really common thing when working with Symfony/doctrine (thanks to autowire/autoconfigure) so the @throws annotation will be more useful on the interface.

[VincentLanglet]

Should I target 1.3.x or 1.4.x @ondrejmirtes ?

[ondrejmirtes]

1.3.x

[VincentLanglet]

1.3.x

Thanks, done

[ondrejmirtes]

Thank you.

[VincentLanglet]

Hi @ondrejmirtes, I think this PR doesn't work and I'm not sure why.

I'm still getting a dead catch error when writing

try {
     $entityManager->flush();
} catch (ORMException|UniqueConstraintViolationException) {}

I can reproduce the bug if I had @throws void in the ObjectManager class but I cannot reproduce the error in the PHPStan tests yet, even with implicitThrows: false...

I think it's because flush method is in the ObjectManager
https://github.com/doctrine/persistence/blob/3.2.x/src/Persistence/ObjectManager.php#L94
and not in the EntityManagerInterface.

Is there a way to say to PHPStan that ORMException|UniqueConstraintViolationException can be thrown by EntityManagerInterface::flush without adding those exception to ObjectManager::flush ?

[ondrejmirtes]

@VincentLanglet It could be done only with a dynamic throw type extension.

[VincentLanglet]

@VincentLanglet It could be done only with a dynamic throw type extension.

Thanks for the advice, I made #486
I check the branch on my personal project, it solves indeed the error.