Declare getReflectionClass as covariant #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What I don't understand is why the error in the stubs does not show up here https://github.com/phpstan/phpstan-doctrine/actions/workflows/build.yml?query=branch%3A2.0.x and only in analysed projects (when the stub error filtering breaks). |
Indeed... It's weird because locally on PHP 8.4 after a composer update, I have the error on the phpstan-doctrine repository |
|
@ondrejmirtes I found the reason, I can reproduce the error with #710 |
ondrejmirtes
force-pushed
the
covariantReflectionClass
branch
from
512be18 to
76b02b1
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #663
Closes #646
This is maybe not perfect, but this is the choice of doctrine/persistence
PR on 5.x https://github.com/doctrine/persistence/pull/473/files#diff-546eb60e406d89362faee89bd404217c4f74305586b791ad1198ff6405c5fdbc
Backport doctrine/persistence#476