Fix return type on EntityRepository::matching() generics#743
Merged
VincentLanglet merged 9 commits intophpstan:2.0.xfrom May 5, 2026
Merged
Fix return type on EntityRepository::matching() generics#743VincentLanglet merged 9 commits intophpstan:2.0.xfrom
VincentLanglet merged 9 commits intophpstan:2.0.xfrom
Conversation
VincentLanglet
changed the title
staabm
reviewed
May 5, 2026
| @@ -0,0 +1,45 @@ | |||
| <?php | |||
|
|
|||
| namespace RepositoryMatching; | |||
Contributor
There was a problem hiding this comment.
this namespaces overlapps with tests/DoctrineIntegration/data/repositoryMatching-collection26.php
Contributor
There was a problem hiding this comment.
it seems we are missing a CI check for unique symbol names (like we have on phpstan-src)
staabm
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @staabm Don't release after this merge, I'll plan to do more PR.